Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk insert in sql document stores #2264

Merged
merged 10 commits into from
Mar 9, 2022

Conversation

OmniscienceAcademy
Copy link
Contributor

@OmniscienceAcademy OmniscienceAcademy commented Mar 1, 2022

Proposed changes:

https://docs.sqlalchemy.org/en/14/faq/performance.html#i-m-inserting-400-000-rows-with-the-orm-and-it-s-really-slow

image

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

@ZanSara
Copy link
Contributor

ZanSara commented Mar 3, 2022

Hey @OmniscienceAcademy, looks good! I took the liberty to edit slightly your code to make it more readable. I hope the changes do not sensibly impact code speed: if they do, we can always revert them.

I'll wait for a green light from you before approving and merging, so let me know 🙂

@OmniscienceAcademy
Copy link
Contributor Author

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants