Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to deploy and undeploy Pipelines on Deepset Cloud #2285

Merged
merged 12 commits into from
Mar 10, 2022
Merged

Allow to deploy and undeploy Pipelines on Deepset Cloud #2285

merged 12 commits into from
Mar 10, 2022

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented Mar 7, 2022 •
edited

Proposed changes:

  • add deploy_on_deepset_cloud and undeploy_on_deepset_cloud to BasePipeline
  • both methods block until success or timeout exceeds
  • both methods poll for status updates using a 5 second interval
  • success is logged as INFO, otherwise an error is raised

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests

closes #2258

@tstadel tstadel marked this pull request as ready for review March 8, 2022 15:18
julian-risch
julian-risch approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In fact, the code looks super clean. Very nice! 👍

@julian-risch
Copy link
Member

Let's not forget about PR labels though. 😉

@tstadel tstadel added journey:advanced type:feature New feature or request labels Mar 9, 2022
ArzelaAscoIi
ArzelaAscoIi approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@ArzelaAscoIi ArzelaAscoIi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good job!

@tstadel tstadel merged commit fd46a42 into master Mar 10, 2022
@tstadel tstadel deleted the deploy_on_dc branch March 10, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

@ArzelaAscoIi ArzelaAscoIi ArzelaAscoIi approved these changes

Assignees
No one assigned
Labels
topic:pipeline type:feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipeline.deploy_on_deepset_cloud() and Pipeline.undeploy_on_deepset_cloud()
3 participants
@tstadel @julian-risch @ArzelaAscoIi