Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dpr with embeddingretriever tut11 #2287

Merged
merged 10 commits into from
Mar 15, 2022
Merged

Replace dpr with embeddingretriever tut11 #2287

merged 10 commits into from
Mar 15, 2022

Conversation

mkkuemmel
Copy link
Member

Proposed changes:

  • Replaced the DensePassageRetriever with EmbeddingRetriever and changed the images accordingly. Image links still have to be generated. Additionally, fixed an issue with running the debug mode of the pipeline in the end.

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@brandenchan
Copy link
Contributor

Waiting on the outcome of #2298 before proceeding

@mkkuemmel mkkuemmel merged commit a1040a1 into master Mar 15, 2022
@mkkuemmel mkkuemmel deleted the replace_dpr_with_embeddingretriever_tut11 branch March 15, 2022 07:30
@bglearning bglearning mentioned this pull request Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandenchan brandenchan brandenchan approved these changes

Assignees
No one assigned
Labels
topic:DPR topic:pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkkuemmel @brandenchan