Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding quotes for zsh shell issue #2289

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Conversation

TuanaCelik
Copy link
Member

Proposed changes:

  • Adding quotes around square brackets in install commands to go around the zsh shell issue. Works for others as well
    @ZanSara, I'll also add quotes to the line in import_utils.py below:
def _optional_component_not_installed(component: str, dep_group: str, source_error: Exception):
    raise ImportError(
        f"Failed to import '{component}', "
        "which is an optional component in Haystack.\n"
        f"Run 'pip install farm-haystack[{dep_group}]' "
        "to install the required dependencies and make this component available."
    ) from source_error

What this prompt suggests will also result in zsh: no matches found: farm-haystack[crawler].
But let me know if I should keep them out here.

Status (please check what you already did):

  • [ x] First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

@TuanaCelik TuanaCelik requested a review from ZanSara March 8, 2022 16:25
@TuanaCelik TuanaCelik self-assigned this Mar 8, 2022
@ZanSara ZanSara merged commit a97a9d2 into master Mar 8, 2022
@ZanSara ZanSara deleted the fixing-readme-with-quotes branch March 8, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants