Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mutation of documents in write_documents() #231

Merged
merged 2 commits into from Jul 15, 2020
Merged

Remove mutation of documents in write_documents() #231

merged 2 commits into from Jul 15, 2020

Conversation

tanaysoni
Copy link
Contributor

No description provided.

tholor
tholor requested changes Jul 15, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MyPy in CI is failing

@tanaysoni tanaysoni merged commit 4e10a15 into master Jul 15, 2020
@tanaysoni tanaysoni deleted the fix-doc-mutation branch July 15, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tanaysoni @tholor