Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YAML pipeline paths in docker-compose.yml #2335

Merged
merged 7 commits into from
Mar 21, 2022

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Mar 21, 2022

Closes #2324

Problem:
The quick demo did not validate the YAML for indexing pipelines and, when we renamed the YAML files to enable automatic validation in the IDE, we forgot to update the paths in the docker-compose* files. The YAML loading did not fail for non-existing files, and his lead to a cryptic error where it seemed that pipelines was not defined in the pipeline file.

Solution

  • FIx the paths in docker-compose.yml and docker-compose-gpu.yml
  • Add check for non-existing files in read_pipeline_config_from_yaml
  • Modify the REST API indexing pipeline load procedure to validate the config file
  • Add note about IDE autocompletion in the YAML files

@ZanSara ZanSara changed the title Fix yaml names docker compose Fix YAML pipeline paths in docker-compose.yml Mar 21, 2022
@ZanSara
Copy link
Contributor Author

ZanSara commented Mar 21, 2022

@julian-risch: Apparently somebody did not wait for the CI to finish before merging their PR and now I have unrelated changed related to the evaluation in my PR. Shall we let them into this one?

…/haystack into fix_yaml_names_docker_compose
@julian-risch
Copy link
Member

@julian-risch: Apparently somebody did not wait for the CI to finish before merging their PR and now I have unrelated changed related to the evaluation in my PR. Shall we let them into this one?

Yes, let's do that. You're referring to docs/_src/api/api/evaluation.md for example, correct?

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ZanSara ZanSara merged commit 5454d57 into master Mar 21, 2022
@ZanSara ZanSara deleted the fix_yaml_names_docker_compose branch March 21, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't get quick demo to run
2 participants