Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change document attribute from text to content #2352

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Change document attribute from text to content #2352

merged 2 commits into from
Mar 23, 2022

Conversation

julian-risch
Copy link
Member

Proposed changes:

  • A comment in the tutorial described Document as having a text attribute. This has been renamed to content.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

TuanaCelik
TuanaCelik approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@TuanaCelik TuanaCelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES!

@TuanaCelik TuanaCelik merged commit cec0137 into master Mar 23, 2022
@TuanaCelik TuanaCelik deleted the fix_tutorial_1_doc_content branch March 23, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TuanaCelik TuanaCelik TuanaCelik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julian-risch @TuanaCelik