changing the name of the retrievers from es_retriever to retriever #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
julian-risch
requested changes
May 3, 2022
There was a problem hiding this comment.
As some of the tutorials use multiple retrievers, for example, BM25Retriever and EmbeddingRetriever, we shouldn't call the variable just plain retriever. A better alternative is bm25_retriever or sparse_retriever. Tutorial 11 is definitely such a case but please check whether there is the same problem in the other tutorials.
And don't forget to put a label on every PR. I just did it now 🙂
…tack into fixing-tutotials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for the variable names in the tutorials so that they are no longer 'es_retriever'
Status (please check what you already did):