Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dot_product metric #2494

Merged
merged 1 commit into from
May 4, 2022
Merged

fix dot_product metric #2494

merged 1 commit into from
May 4, 2022

Conversation

jamescalam
Copy link
Contributor

@jamescalam jamescalam commented May 3, 2022 •
edited

Proposed changes:

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

closes #2493

@julian-risch julian-risch self-requested a review May 4, 2022 07:18
julian-risch
julian-risch approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thank you for contributing this fix.

@julian-risch julian-risch merged commit a0bf340 into deepset-ai:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

Assignees
No one assigned
Labels
topic:pinecone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error for dotproduct metric in PineconeDocumentStore
2 participants
@jamescalam @julian-risch