fix pipeline run loop on joined pipelines whithout debug flag #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstadel
added
type:bug
julian-risch
requested changes
Jul 7, 2022
haystack/pipelines/base.py
Outdated
| "_debug": {**existing_input["_debug"], **node_output["_debug"]}, | ||
| } | ||
| updated_input: dict = {"inputs": [existing_input, node_output], "params": params} | ||
| if "_debug" in existing_input.keys() or "_debug" in node_output: |
There was a problem hiding this comment.
existing_input and node_output are both dictionaries right? So I would suggest to check with the same approach whether they contain the "_debug" key. Or is there a specific reason to not do that?
Krak91
pushed a commit
to Krak91/haystack
that referenced
this pull request
Jul 26, 2022
…t-ai#2777) * fix pipeline run loop on joined pipelines whithout debug flag * use .keys() consistently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Fixes the broken tests of PR #2776
Proposed changes:
_debugis actual there before merging it