Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: fix UnboundLocalError in Pipeline.run_batch() #3016

Merged
merged 1 commit into from Aug 10, 2022
Merged

bug: fix UnboundLocalError in Pipeline.run_batch() #3016

merged 1 commit into from Aug 10, 2022

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

As explained in #2985, I simply moved flattened_documents definition

How did you test it?

Manual test using the code proposed by @ZanSara in #2985.
Now UnboundLocalError is not raised anymore.

Checklist

@anakin87 anakin87 requested a review from a team as a code owner August 10, 2022 10:16
ZanSara
ZanSara approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😊

@ZanSara ZanSara merged commit 5778b6f into deepset-ai:master Aug 10, 2022
@anakin87 anakin87 deleted the fix_pipeline_run_batch_bug branch August 10, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara approved these changes

Assignees
No one assigned
Labels
topic:pipeline type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipeline.run_batch() fails on indexing
2 participants
@anakin87 @ZanSara