feat: Adds all_terms_must_match parameter to BM25Retriever at runtime #3627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Unai Garay <unaigaraymaestre@gmail.com>
ZanSara
requested review from
ZanSara and
mayankjobanputra
and removed request for
bogdankostic and
ZanSara
…/github.com/ugm2/haystack into feat/add_all_terms_must_match_bm25_retrieve
mayankjobanputra
added
type:feature
|
@ugm2 Thanks for opening the PR. I will get back to you on this in a day :) |
mayankjobanputra
requested changes
Dec 1, 2022
ugm2
commented
Dec 6, 2022
I am looking into it! :) |
agnieszka-m
requested changes
Dec 7, 2022
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
Co-authored-by: Agnieszka Marzec <97166305+agnieszka-m@users.noreply.github.com>
ugm2
requested review from
mayankjobanputra and
agnieszka-m
and removed request for
mayankjobanputra and
agnieszka-m
mayankjobanputra
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
all_terms_must_matchinBM25Retrievershould be able to be passed at runtime too #3613Proposed Changes:
Adds
all_terms_must_matchas a runtime parameter to BM25Retriever. This allows the user to switch between partial or full matching of words without having to recreate the Node or the Pipeline.How did you test it?
I added a unit test where I test passing the parameter to both the init and the run functions.
Checklist