Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust get_type() method for pipelines #3657

Merged
merged 3 commits into from
Dec 2, 2022
Merged

Adjust get_type() method for pipelines #3657

merged 3 commits into from
Dec 2, 2022

Conversation

vblagoje
Copy link
Member

@vblagoje vblagoje commented Dec 1, 2022

Related Issues

Proposed Changes:

get_type() misclassified some pipelines as "Unknown pipeline". These pipelines are now properly classified by type.

How did you test it?

Unit test, see PR diff

Notes for the reviewer

Any other test cases from telemetry?

Checklist

@vblagoje vblagoje requested a review from a team as a code owner December 1, 2022 18:55
@vblagoje vblagoje requested review from masci and julian-risch and removed request for a team and masci December 1, 2022 18:55
@vblagoje
Copy link
Member Author

vblagoje commented Dec 2, 2022

@julian-risch I added several tests that now correctly return the right pipeline type instead of "Unknown pipeline." Now we rely on types of objects to deduce the pipeline type rather than names which were not standardized to begin with. Please have a look.

Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍 This is a nice improvement of what we had before. I don't see a need for adding test cases for all the different pipeline types. From my point of view the test that you added is sufficient.
The only point I was thinking about is the TranslationWrapperPipeline. If a pipeline contains two BaseTranslator components we would now know that it is a TranslationWrapperPipeline but we wouldn't know what else is in the pipeline (DocumentSearch, ExtractiveQA, etc.). However, it's okay that way. We still have the detailed list of components if more details are needed.

@vblagoje vblagoje merged commit e4c3817 into deepset-ai:main Dec 2, 2022
@vblagoje vblagoje deleted the telemetry_new branch March 31, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve pipeline telemetry
2 participants