proposal: TableCell #3875
Merged
proposal: TableCell #3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrl
requested review from
julian-risch,
bglearning and
ju-gu
and removed request for
a team
ZanSara
reviewed
Jan 17, 2023
sjrl
force-pushed
the
proposal-table-span
branch
from
2a7b50b
to
27338b8
Compare
sjrl
force-pushed
the
proposal-table-span
branch
from
27338b8
to
72e0430
Compare
…point to make it clear that we will be able to return a List of TableCells
julian-risch
approved these changes
Jan 27, 2023
|
@sjrl As per our proposal process you need approval from two more reviewers before merging. In addition to @ZanSara , either @ju-gu or @bglearning might be able to do that or you need to assign one more reviewer. 🙂 |
This was referenced Jan 27, 2023
bglearning
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Looks good to me! Will definitely improve TableQA experience for users.
The switch to List[List] from DataFrame for table content representation also seems good for consistency.
(Further discussion on the internal format of tables in haystack Documents can be done at a later time. #3999 )
sjrl
added
proposal:active
This was referenced Feb 9, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
Adding proposal for the addition of a
TableCellprimitive/dataclass.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.