fixing ElasticsearchDocumentStore initialisation #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, Elasticsearch creates an index called document. That's the biggest problem when initializing ElasticsearchDocumentStore through Haystack. Because when calling `_create_document_index`, you may end up doing nothing since `document` index is already created. This is not a problem for non-vector Retriever. But Embeddings needs special type "dense_vector" into Elasticsearch mapping definition. That's why it is important to update the default 'document' index in this case.
|
Hi @guillim, thank you for the PR! I just added a check to ensure we don't overwrite an existing field. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Elasticsearch creates an index called document. That's the biggest problem when initializing ElasticsearchDocumentStore through Haystack. Because when calling
_create_document_index, you may end up doing nothing sincedocumentindex is already created. This is not a problem for non-vector Retriever.But Embeddings needs special type "dense_vector" into Elasticsearch mapping definition. That's why it is important to update the default 'document' index in this case.