Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Jupyter notebooks of Tutorials #43

Merged
merged 3 commits into from
Mar 17, 2020
Merged

Added Jupyter notebooks of Tutorials #43

merged 3 commits into from
Mar 17, 2020

Conversation

bogdankostic
Copy link
Contributor

I added Jupyter notebooks for tutorial 2 and 3.

@Timoeller
Copy link
Contributor

Looking good.
One general remark: I think it is useful to keep informative outputs in the jupyter and colab notebook. So if people open that file on github/colab they already see what can be expected.
Other useless output, e.g. the install output in colab should be deleted.

Timoeller
Timoeller approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

tutorials/Tutorial2_Finetune_a_model_on_your_data.ipynb Outdated Show resolved Hide resolved
@Timoeller Timoeller removed the request for review from tanaysoni March 17, 2020 16:54
@Timoeller Timoeller self-assigned this Mar 17, 2020
Timoeller
Timoeller reviewed Mar 17, 2020
View reviewed changes
README.rst Outdated Show resolved Hide resolved
@Timoeller Timoeller merged commit 0048ee9 into master Mar 17, 2020
@julian-risch julian-risch deleted the tutorials branch November 15, 2021 07:05
@masci masci mentioned this pull request May 4, 2023
Closed
masci pushed a commit that referenced this pull request Nov 27, 2023
@ZanSara
Merge pull request #43 from deepset-ai/more-tests
9d3bed2 
chore: some more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timoeller Timoeller Timoeller approved these changes

Assignees

@Timoeller Timoeller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bogdankostic @Timoeller