Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable bulk operations on vector IDs for FAISSDocumentStore #460

Merged
merged 3 commits into from
Oct 2, 2020
Merged

Enable bulk operations on vector IDs for FAISSDocumentStore #460

merged 3 commits into from
Oct 2, 2020

Conversation

tanaysoni
Copy link
Contributor

@tanaysoni tanaysoni commented Oct 2, 2020 •
edited
Loading

With this PR, the SQLDocumentStore has a new vector_id field in the document table.

The FAISSDocumentStore now uses the new methods get_documents_by_vector_ids() & update_vector_ids() to perform bulk read & writes on vector_ids in the SQLDocumentStore.

Resolves #383.

@tanaysoni tanaysoni changed the title WIP: Enable bulk operations based on vector IDs for FAISSDocumentStore Enable bulk operations based on vector IDs for FAISSDocumentStore Oct 2, 2020
@tanaysoni tanaysoni requested a review from tholor October 2, 2020 12:22
tholor
tholor approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@tanaysoni tanaysoni changed the title Enable bulk operations based on vector IDs for FAISSDocumentStore Enable bulk operations on vector IDs for FAISSDocumentStore Oct 2, 2020
@tanaysoni tanaysoni merged commit 669c72d into master Oct 2, 2020
@tanaysoni tanaysoni deleted the sql-vector-id branch October 2, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve performance for updating & querying vector_ids in the FAISSDocumentStore
2 participants
@tanaysoni @tholor