Add Elasticsearch Query DSL compliant Query API #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanaysoni
reviewed
Oct 9, 2020
lalitpagaria
changed the title
lalitpagaria
commented
Oct 12, 2020
| from haystack import Finder | ||
| from haystack.retriever.sparse import ElasticsearchRetriever | ||
|
|
||
| # TODO: Add integration tests for other APIs |
There was a problem hiding this comment.
This is not part of this PR hence adding comment and tests can be added with another PRs
|
@tanaysoni PR is ready for the full review. |
|
@tanaysoni Just checking if you got a chance to review this PR. |
|
Thank you @lalitpagaria for working on it! It looks good-to-go 🚀 |
|
Thanks @tanaysoni |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To complete #429
Using very dummy way to convert request object in ES Query DSL to Question object. As this simple conversion hence there is no need to add other 3 party libs.
@tanaysoni Please share your feedback and also check
TODO:comments