Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preprocessing pipeline #473

Merged
merged 9 commits into from
Oct 15, 2020
Merged

Add preprocessing pipeline #473

merged 9 commits into from
Oct 15, 2020

Conversation

tanaysoni
Copy link
Contributor

Resolves #381

Copy link

@flozi00 flozi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool, left some questions and suggestions @tholor

haystack/preprocessor/preprocessor.py Outdated Show resolved Hide resolved
haystack/preprocessor/preprocessor.py Outdated Show resolved Hide resolved
haystack/preprocessor/preprocessor.py Show resolved Hide resolved
@prairitm
Copy link

Hey, great change in the pipeline, as large documents increase reader inference time.
How can we implement the new preprocessing pipeline in api with file upload?

@tholor
Copy link
Member

tholor commented Oct 15, 2020

@prairitm we expect to finish this PR today. We will then test the new PreProcessor a bit in practice to see if we need to iterate further on the design. The integration into the file upload API will then probably follow in the next 2-3 weeks, but you could of course already give it a try yourself.

@tanaysoni tanaysoni changed the title WIP: Add preprocessing pipeline Add preprocessing pipeline Oct 15, 2020
@tholor tholor merged commit 974b37e into master Oct 15, 2020
@julian-risch julian-risch deleted the preprocessing branch November 15, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Preprocessor class that does splitting and cleaning
4 participants