Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Update unit tests for schema #4835

Merged
merged 6 commits into from
May 10, 2023
Merged

test: Update unit tests for schema #4835

merged 6 commits into from
May 10, 2023

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented May 8, 2023 •
edited
Loading

Related Issues

  • fixes N/A

Proposed Changes:

How did you test it?

  • Existing and updated unit tests.

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels May 8, 2023
@coveralls
Copy link
Collaborator

coveralls commented May 8, 2023 •
edited
Loading

Coverage Status

Coverage: 36.867% (+0.3%) from 36.572% when pulling 3d8e21f on unit-test-schema into 6e982e9 on main.

@sjrl sjrl marked this pull request as ready for review May 8, 2023 10:58
@sjrl sjrl requested a review from a team as a code owner May 8, 2023 10:58
@sjrl sjrl requested review from ZanSara and removed request for a team May 8, 2023 10:58
sjrl
sjrl commented May 8, 2023
View reviewed changes
haystack/schema.py Show resolved Hide resolved
silvanocerza
silvanocerza requested changes May 8, 2023
View reviewed changes
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all the PR is great, I would just make the change from the comment I left and it's 👍 for me.

@sjrl sjrl requested a review from silvanocerza May 10, 2023 08:03
silvanocerza
silvanocerza approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sjrl sjrl merged commit eff420c into main May 10, 2023
@sjrl sjrl deleted the unit-test-schema branch May 10, 2023 14:16
@masci
Copy link
Contributor

masci commented May 23, 2023

I'm removing the breaking change label as I'm struggling explaining why this is breaking in the release notes...

@ZanSara ZanSara removed their request for review July 5, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZanSara ZanSara ZanSara left review comments

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sjrl @coveralls @masci @silvanocerza @ZanSara