Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deepcopy for meta dicts in answers #485

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Add deepcopy for meta dicts in answers #485

merged 1 commit into from
Oct 14, 2020

Conversation

tanaysoni
Copy link
Contributor

In the Finder, for each answer object, the corresponding document's meta is added. In the case of multiple answers from the same document, the answers' meta references to the same dictionary in memory. This could lead to unintended behavior where changes to the meta of an answer get propagated to the meta of others answers.

@tanaysoni tanaysoni requested a review from tholor October 14, 2020 09:50
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sneaky one!

@tanaysoni tanaysoni merged commit 3c6a125 into master Oct 14, 2020
@tanaysoni tanaysoni deleted the fix-finder-meta branch October 14, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants