Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoteWhisperTranscriber (v2) #4910

Merged
merged 14 commits into from
May 22, 2023
Merged

RemoteWhisperTranscriber (v2) #4910

merged 14 commits into from
May 22, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented May 12, 2023 •
edited
Loading

Related Issues

Proposed Changes:

  • Adds RemoteWhisperTranscriber
  • Adds its unit tests and a e2e test

How did you test it?

  • Local test runs
  • CI

Notes for the reviewer

n/a

@ZanSara ZanSara added the 2.x Related to Haystack v2.0 label May 12, 2023
@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels May 12, 2023
@ZanSara ZanSara linked an issue May 15, 2023 that may be closed by this pull request
Port WhisperTranscriber to v2 pipelines #4837
Closed
@coveralls
Copy link
Collaborator

coveralls commented May 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5046479181

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 39.381%
Totals Coverage Status
Change from base Build 5015111315: 0%
Covered Lines: 8813
Relevant Lines: 22379
💛 - Coveralls

@ZanSara ZanSara marked this pull request as ready for review May 17, 2023 12:56
@ZanSara ZanSara requested a review from a team as a code owner May 17, 2023 12:56
@ZanSara ZanSara requested review from silvanocerza and removed request for a team May 17, 2023 12:56
@ZanSara ZanSara requested a review from silvanocerza May 17, 2023 17:17
@ZanSara ZanSara merged commit 516db4c into main May 22, 2023
52 checks passed
@ZanSara ZanSara deleted the v2-whisper-remote branch May 22, 2023 14:03
@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label May 23, 2023
@ZanSara ZanSara mentioned this pull request Jul 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:dependencies topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port WhisperTranscriber to v2 pipelines
4 participants
@ZanSara @coveralls @silvanocerza @masci