Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove BaseKnowledgeGraph #4953

Merged
merged 3 commits into from
May 21, 2023
Merged

chore: remove BaseKnowledgeGraph #4953

merged 3 commits into from
May 21, 2023

Conversation

masci
Copy link
Contributor

@masci masci commented May 18, 2023

Related Issues

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@masci masci requested a review from a team as a code owner May 18, 2023 09:45
@masci masci requested review from vblagoje and removed request for a team May 18, 2023 09:45
@masci masci mentioned this pull request May 18, 2023
Closed
2 tasks
@github-actions github-actions bot added the type:documentation Improvements on the docs label May 18, 2023
@coveralls
Copy link
Collaborator

coveralls commented May 18, 2023 •
edited
Loading

Coverage Status

Coverage: 38.577% (+0.005%) from 38.572% when pulling 2209c53 on massi/knowledgegraph-remove into df55ec5 on main.

vblagoje
vblagoje approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masci masci merged commit c6ea542 into main May 21, 2023
71 checks passed
@masci masci deleted the massi/knowledgegraph-remove branch May 21, 2023 08:42
@masci masci mentioned this pull request May 21, 2023
Merged
6 tasks
@julian-risch julian-risch mentioned this pull request May 23, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vblagoje vblagoje vblagoje approved these changes

Assignees
No one assigned
Labels
breaking change topic:document_store topic:knowledge_graph topic:retriever topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@masci @coveralls @vblagoje