Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pin typing_extensions to fix Pydantic issue #4987

Merged
merged 1 commit into from
May 23, 2023
Merged

fix: Pin typing_extensions to fix Pydantic issue #4987

merged 1 commit into from
May 23, 2023

Conversation

silvanocerza
Copy link
Contributor

Proposed Changes:

Pin typing_extensions to version 4.5.0 to fix Pydantic failing when trying to import Haystack.

typing_extensions version 4.6.0 was released 8 hours ago, that version causes Pydantic to fail.

How did you test it?

Created a new virtualenv with Python 3.8.16, run pip install . and then python -c 'import haystack'.

Notes for the reviewer

Some additional info regarding the failure in here can be found in the Pydantic issue: pydantic/pydantic#5821.

Imports have been moved around in schema.py to please pylint.

@silvanocerza silvanocerza self-assigned this May 23, 2023
@silvanocerza silvanocerza requested a review from a team as a code owner May 23, 2023 08:42
@silvanocerza silvanocerza requested review from julian-risch and masci and removed request for a team May 23, 2023 08:42
ZanSara
ZanSara approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@ZanSara ZanSara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

julian-risch
julian-risch approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 I wondered why you moved typing_extensions from dev extras to the core dependencies but I assume the pinning didn't work as intended otherwise? As soon as the pinning can be removed, we should move it back to the dev dependencies.

@silvanocerza
Copy link
Contributor Author

@julian-risch yup, if I had left it in dev it would not work when people installed Haystack with pip install . or any extras.

@silvanocerza silvanocerza merged commit afc342b into main May 23, 2023
50 checks passed
@silvanocerza silvanocerza deleted the fix-pydantic-issue branch May 23, 2023 09:08
@silvanocerza silvanocerza mentioned this pull request May 23, 2023
Closed
@masci masci added this to the 1.17 milestone May 23, 2023
masci pushed a commit that referenced this pull request May 23, 2023
@silvanocerza @masci
Pin typing_extensions to fix Pydantic issue (#4987)
f47eefd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

@ZanSara ZanSara ZanSara approved these changes

@masci masci Awaiting requested review from masci

Assignees

@silvanocerza silvanocerza

Labels
topic:build/distribution topic:dependencies
Projects
None yet
Milestone
1.17
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@silvanocerza @julian-risch @ZanSara @masci