Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Delete outdated benchmark files #5008

Merged
merged 2 commits into from
Jun 1, 2023
Merged

refactor: Delete outdated benchmark files #5008

merged 2 commits into from
Jun 1, 2023

Conversation

bogdankostic
Copy link
Contributor

Related Issues

Proposed Changes:

This PR deletes outdated benchmark files.

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@bogdankostic bogdankostic mentioned this pull request May 23, 2023
Closed
@bogdankostic bogdankostic changed the title refactor Delete outdated benchmark files refactor: Delete outdated benchmark files May 23, 2023
@coveralls
Copy link
Collaborator

coveralls commented May 23, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5093127905

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 39.619%
Totals Coverage Status
Change from base Build 5093124690: 0.0%
Covered Lines: 8875
Relevant Lines: 22401
💛 - Coveralls

@bogdankostic bogdankostic marked this pull request as ready for review May 26, 2023 16:48
@bogdankostic bogdankostic requested review from a team as code owners May 26, 2023 16:48
@bogdankostic bogdankostic requested review from masci and removed request for a team May 26, 2023 16:48
masci
masci approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@bogdankostic bogdankostic merged commit c3e5991 into main Jun 1, 2023
100 checks passed
@bogdankostic bogdankostic deleted the delete_outdated_benchmark_files branch June 1, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bogdankostic @coveralls @masci