Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirement to colab notebooks #509

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Add requirement to colab notebooks #509

merged 1 commit into from
Oct 23, 2020

Conversation

bogdankostic
Copy link
Contributor

Fixes #507.

Google colab environments have preinstalled urllib3==1.24.3, but botocore 1.19.0 needs urllib3<1.26,>=1.25.4. This PR adds a pip install for urllib3==1.25.4 on all colab examples.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tholor tholor added this to the #3 milestone Oct 21, 2020
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a quick fix this is ok, but if Google Colab keeps these incompatible versions we should midterm rather move this into haystacks requirements.txt

@tholor tholor merged commit f62117c into master Oct 23, 2020
@julian-risch julian-risch deleted the add_colab_requirement branch November 15, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import error on Colab for: from haystack.preprocessor.utils import fetch_archive_from_http
2 participants