Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent parameter naming for TransformersReader #510

Merged
merged 2 commits into from Oct 21, 2020
Merged

Consistent parameter naming for TransformersReader #510

merged 2 commits into from Oct 21, 2020

Conversation

lalitpagaria
Copy link
Contributor

  • Changing TransformersReader parameter from model to model_name_or_path to make it consistent with FARMReader
  • Removing unused imports as well.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@lalitpagaria
Copy link
Contributor Author

@tholor can you please add breaking change label

@lalitpagaria
Copy link
Contributor Author

Interesting test job is getting killed with error code 137 means docker container killed because OOM -

2020-10-20T17:08:37.1255514Z test_eval.py ...........                                                 [ 56%]
2020-10-20T17:09:28.3133855Z test_faiss.py .........                                                  [ 63%]
2020-10-20T17:17:18.4233618Z /home/runner/work/_temp/a2641cfd-a0dc-4e88-8daa-f54674f5708c.sh: line 1:  4065 Killed                  pytest
2020-10-20T17:17:18.4253736Z test_finder.py ...................
2020-10-20T17:17:18.6246336Z ##[error]Process completed with exit code 137.

@lalitpagaria
Copy link
Contributor Author

I dont see any option to re-run the build, I think it might be related to some permission.
I don't think this change may cause any memory issue.

tholor
tholor requested changes Oct 21, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @lalitpagaria ! Left minor comments ...

docs/v0.4.0/_src/tutorials/tutorials/1.md Outdated Show resolved Hide resolved
tutorials/Tutorial1_Basic_QA_Pipeline.ipynb Show resolved Hide resolved
@lalitpagaria lalitpagaria removed their assignment Oct 21, 2020
tholor
tholor approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Ready to merge :)

@tholor tholor merged commit 63c1237 into deepset-ai:master Oct 21, 2020
@lalitpagaria lalitpagaria deleted the reader_parameter_naming_consitancy branch October 21, 2020 15:24
@antoniolanza1996 antoniolanza1996 mentioned this pull request Nov 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lalitpagaria @tholor