Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requests_cache in tests #5285

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Remove requests_cache in tests #5285

merged 1 commit into from
Jul 6, 2023

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Jul 6, 2023

Proposed Changes:

Remove caching of requests to huggingface.co when running tests to integration tests failures.
huggingface_hub already handles caching by itself as documented so this shouldn't affect our limits.

How did you test it?

I ran CI with PR #5282 to troubleshoot the issue, turns out that removing cache makes tests run correctly.

Notes for the reviewer

The failures weren't reproducible locally while running individual tests.
Failures examples: https://github.com/deepset-ai/haystack/actions/runs/5473396123

Checklist

@silvanocerza silvanocerza self-assigned this Jul 6, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jul 6, 2023

Pull Request Test Coverage Report for Build 5474238866

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 44.607%

Files with Coverage Reduction New Missed Lines %
utils/context_matching.py 1 91.67%
Totals Coverage Status
Change from base Build 5473396123: -0.005%
Covered Lines: 10265
Relevant Lines: 23012

💛 - Coveralls

@silvanocerza silvanocerza marked this pull request as ready for review July 6, 2023 10:10
@silvanocerza silvanocerza requested a review from a team as a code owner July 6, 2023 10:10
@silvanocerza silvanocerza requested review from vblagoje and removed request for a team July 6, 2023 10:10
@silvanocerza silvanocerza merged commit a1a3900 into main Jul 6, 2023
55 checks passed
@silvanocerza silvanocerza deleted the uncache-tests branch July 6, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants