fix: Support isolated node eval in run_batch in Generators #5291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
PromptNode
doesn't support isolated node evaluation #3275Proposed Changes:
This PR adds the parameter
add_isolated_node_eval
to therun_batch
method of theBaseGenerator
. This is needed for cases where a user callseval_batch
on a Pipeline withadd_isolated_node_eval=True
. Previously, this parameter was just ignored.How did you test it?
I added two unit tests, one for
run
and one forrun_batch
.Notes for the reviewer
I moved the
EVAL_LABELS
fromtest_eval.py
to a fixture inconftest.py
to be able to use them intest_generator.py
.Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.