Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing warnings from the Haystack codebase. #530

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Removing warnings from the Haystack codebase. #530

merged 1 commit into from
Nov 2, 2020

Conversation

lalitpagaria
Copy link
Contributor

Fixes: #526

  1. Few warnings need fix in FARM
  2. Can't remove warning from docx library

@lalitpagaria
Copy link
Contributor Author

@tholor please review

tholor
tholor requested changes Nov 2, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Looking good except for the conflicts with master. The changes within dense.py are outdated, as we refactored DPR heavily in #527

@lalitpagaria
Removing warnings from the Haystack codebase.
e84f8ed 
1. Few warnings need fix in FARM
2. Can't remove warning from docx library.
@lalitpagaria
Copy link
Contributor Author

Thanks for fixing this! Looking good except for the conflicts with master. The changes within dense.py are outdated, as we refactored DPR heavily in #527

Done

tholor
tholor approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tholor tholor merged commit 5d45992 into deepset-ai:master Nov 2, 2020
@lalitpagaria lalitpagaria deleted the fix_warnings branch November 2, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix various "DeprecationWarning" and "RuntimeWarning" from the code
2 participants
@lalitpagaria @tholor