Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add unit test for Elasticsearch8 #5300

Merged
merged 19 commits into from
Jul 10, 2023
Merged

ci: Add unit test for Elasticsearch8 #5300

merged 19 commits into from
Jul 10, 2023

Conversation

bogdankostic
Copy link
Contributor

@bogdankostic bogdankostic commented Jul 10, 2023 •
edited
Loading

Related Issues

Proposed Changes:

This PR creates separate tests for ES8 where needed (because of difference in client calling compared to ES7) and adds running unit tests for ES 8 in the CI.

How did you test it?

Notes for the reviewer

Checklist

@bogdankostic bogdankostic requested a review from a team as a code owner July 10, 2023 08:13
@bogdankostic bogdankostic requested review from julian-risch and removed request for a team July 10, 2023 08:13
@bogdankostic bogdankostic requested review from silvanocerza and removed request for julian-risch July 10, 2023 08:19
@coveralls
Copy link
Collaborator

coveralls commented Jul 10, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5508700084

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 44.991%
Totals Coverage Status
Change from base Build 5505967772: 0.2%
Covered Lines: 10375
Relevant Lines: 23060
💛 - Coveralls

silvanocerza
silvanocerza approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🚀

@bogdankostic bogdankostic merged commit b7f683b into main Jul 10, 2023
64 checks passed
@bogdankostic bogdankostic deleted the es8_unit_test branch July 10, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
topic:CI topic:document_store topic:elasticsearch topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bogdankostic @coveralls @silvanocerza