Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve User Feedback Documentation #539

Merged
merged 3 commits into from Dec 1, 2020
Merged

Improve User Feedback Documentation #539

merged 3 commits into from Dec 1, 2020

Conversation

brandenchan
Copy link
Contributor

This PR improves the docs so they give a better explanation of how User Feedback functions within Haystack

tholor
tholor reviewed Nov 4, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's add more hands-on example for the actual usage:

  • what endpoint to call
  • example request format (what JSON is expected?)
  • how to see the stored labels
  • how to use / export them for training

@tholor tholor added this to the #4 milestone Nov 4, 2020
@brandenchan brandenchan mentioned this pull request Nov 18, 2020
Closed
@tholor tholor modified the milestones: #4, #5 Nov 18, 2020
tholor
tholor reviewed Dec 1, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left a few small comments ...

docs/_src/usage/usage/domain_adaptation.md Show resolved Hide resolved
docs/_src/usage/usage/domain_adaptation.md Outdated Show resolved Hide resolved
docs/_src/usage/usage/domain_adaptation.md Outdated Show resolved Hide resolved
docs/_src/usage/usage/domain_adaptation.md Show resolved Hide resolved
@brandenchan brandenchan merged commit e573c9e into master Dec 1, 2020
@brandenchan brandenchan deleted the user_feedback branch December 1, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor left review comments

Assignees

@tholor tholor

@brandenchan brandenchan

Labels
None yet
Projects
None yet
Milestone
#5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandenchan @tholor