Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration for Elasticsearch Analyzer #554

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Conversation

tanaysoni
Copy link
Contributor

Elasticsearch natively supports different analyzers for dividing a text field into terms, including pre-configured options for different languages. More info here: https://www.elastic.co/guide/en/elasticsearch/reference/7.9/analysis-analyzers.html

With this PR, a new analyzer parameter is added to the ElasticsearchDocumentStore that allows setting a default analyzer from one of the built-in analyzers. This default analyzer will be used both for indexing & query.

Resolves #538

@tanaysoni tanaysoni requested a review from tholor November 5, 2020 11:01
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just edited the docstring a bit. In particular, let's capitalize them from now on as it will render nicer on our documentation website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ElasticSearch Analyzer
2 participants