Add support for MySQL database #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanaysoni
changed the title
lalitpagaria
reviewed
Nov 5, 2020
haystack/document_store/sql.py
Outdated
| value = Column(String, index=True) | ||
| document_id = Column(String, ForeignKey("document.id", ondelete="CASCADE"), nullable=False) | ||
| name = Column(String(100), index=True) | ||
| value = Column(String(100), index=True) |
There was a problem hiding this comment.
Title of the doc is stored as value of meta.name key and there is possibility that it can breach 100 char limit. And if Text is used then need to consider how Text filed is indexed. I feel high value for this would be good ie 1024 or 512.
There was a problem hiding this comment.
Well spotted @lalitpagaria! I switched the value field to Text.
lalitpagaria
reviewed
Nov 5, 2020
haystack/document_store/sql.py
Outdated
| value = Column(String, index=True) | ||
| document_id = Column(String, ForeignKey("document.id", ondelete="CASCADE"), nullable=False) | ||
| name = Column(String(100), index=True) | ||
| value = Column(Text, index=True) |
There was a problem hiding this comment.
As per mysql docs -
BLOB and TEXT columns also can be indexed, but a prefix length must be given.
I think one integration test with mysql will show these issue if any.
There was a problem hiding this comment.
I think we could revert to a larger string field instead of text as you suggested earlier. I tested that the tables get created without any errors on a MySQL instance.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds makes the
SQLDocumentStoremore generic to work with MySQL database.Resolves #543.