Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: temporary pin tiktoken #5774

Merged
merged 2 commits into from
Sep 12, 2023
Merged

fix: temporary pin tiktoken #5774

merged 2 commits into from
Sep 12, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Sep 12, 2023

Related Issues

Release 0.5.0 is breaking

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@ZanSara ZanSara requested a review from a team as a code owner September 12, 2023 08:16
@ZanSara ZanSara requested review from vblagoje and removed request for a team September 12, 2023 08:16
@julian-risch julian-risch requested review from julian-risch and removed request for vblagoje September 12, 2023 08:18
@ZanSara ZanSara added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Sep 12, 2023
julian-risch
julian-risch requested changes Sep 12, 2023
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to use <0.5.0 instead of !=0.5.0. Otherwise we might have the same problem in a few hours again.

julian-risch
julian-risch approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ZanSara ZanSara mentioned this pull request Sep 12, 2023
Closed
@coveralls
Copy link
Collaborator

coveralls commented Sep 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6156766059

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 48.924%
Files with Coverage Reduction New Missed Lines %
utils/context_matching.py 3 93.55%
Totals Coverage Status
Change from base Build 6150513428: -0.01%
Covered Lines: 11841
Relevant Lines: 24203
💛 - Coveralls

@ZanSara ZanSara merged commit 869f69d into main Sep 12, 2023
66 of 67 checks passed
@ZanSara ZanSara deleted the pin-tiktoken branch September 12, 2023 12:35
ZanSara added a commit that referenced this pull request Sep 12, 2023
@ZanSara
fix: temporary pin tiktoken (#5774)
1b5eb85 
* exclude breaking tiktoken version

* exclude breaking tiktoken version
@hauntsaninja hauntsaninja mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZanSara @coveralls @julian-risch