Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filters for delete_all_documents() #591

Merged
merged 5 commits into from
Nov 16, 2020
Merged

Add filters for delete_all_documents() #591

merged 5 commits into from
Nov 16, 2020

Conversation

tanaysoni
Copy link
Contributor

This PR adds a filters parameter(similar to get_all_documents()) to delete_all_documents() for ElasticsearchDocumentStore.

tholor
tholor approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Please only update the docstrings before merging

haystack/document_store/elasticsearch.py Outdated Show resolved Hide resolved
haystack/document_store/memory.py Outdated Show resolved Hide resolved
haystack/document_store/sql.py Outdated Show resolved Hide resolved
@tanaysoni tanaysoni merged commit 3e095dd into master Nov 16, 2020
@tanaysoni tanaysoni deleted the delete-document-filters branch November 16, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tanaysoni @tholor