Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return_embedding parameter for get_all_documents() #615

Merged
merged 10 commits into from
Nov 26, 2020
Merged

Add return_embedding parameter for get_all_documents() #615

merged 10 commits into from
Nov 26, 2020

Conversation

tanaysoni
Copy link
Contributor

@tanaysoni tanaysoni commented Nov 24, 2020 •
edited
Loading

This PR adds a return_embedding parameter for DocumentStore.get_all_document() methods.

Additionally, the default return_embedding parameters are set to False.

@tanaysoni tanaysoni changed the title WIP: Add return_embedding parameter for get_all_documents WIP: Add return_embedding parameter for get_all_documents() Nov 24, 2020
@tanaysoni tanaysoni mentioned this pull request Nov 24, 2020
Closed
tholor
tholor requested changes Nov 24, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Only two minor comments

haystack/document_store/base.py Show resolved Hide resolved
test/test_db.py Outdated Show resolved Hide resolved
@tanaysoni tanaysoni changed the title WIP: Add return_embedding parameter for get_all_documents() Add return_embedding parameter for get_all_documents() Nov 25, 2020
@tanaysoni tanaysoni merged commit ea976ba into master Nov 26, 2020
@tanaysoni tanaysoni deleted the get-all-document-embedding branch November 26, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tanaysoni @tholor