Cleanup Pytest Fixtures #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanaysoni
changed the title
tholor
reviewed
Nov 30, 2020
lalitpagaria
reviewed
Dec 2, 2020
lalitpagaria
suggested changes
Dec 2, 2020
tanaysoni
force-pushed
the
cleanup-pytest-fixture
branch
from
a8bead7
to
dadd0a5
Compare
tanaysoni
force-pushed
the
cleanup-pytest-fixture
branch
from
6880d9c
to
99bf776
Compare
tanaysoni
changed the title
tholor
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes redundant fixtures for document stores and retrievers.