Add support for aggregating scores in JoinDocuments node #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanaysoni
changed the title
tanaysoni
force-pushed
the
join-documents
branch
from
e39abdb
to
8108243
Compare
tholor
requested changes
Dec 15, 2020
tholor
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new
Pipelineclass, a new nodeJoinDocumentswas added to support combining results from multiple retrievers. By default, ajoin_modecalledconcatenatewas implemented to collect documents retrieved by multiple retrievers.This PR adds a new
join_modecalledmergethat can aggregate (weighted) scores for documents returned by multiple retrievers and return the top_k documents.Resolves #125