Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add AnswerExactMatchEvaluator (#7050)" #7075

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Revert "Add AnswerExactMatchEvaluator (#7050)" #7075

merged 1 commit into from
Feb 23, 2024

Conversation

silvanocerza
Copy link
Contributor

This reverts commit b4011af.

We're chaing priority for evaluators and won't be releasing them for 2.0.0 but for 2.1.0.

@silvanocerza silvanocerza self-assigned this Feb 23, 2024
@silvanocerza silvanocerza requested review from a team as code owners February 23, 2024 12:14
@silvanocerza silvanocerza requested review from dfokina and julian-risch and removed request for a team February 23, 2024 12:14
@github-actions github-actions bot added type:documentation Improvements on the docs topic:tests 2.x Related to Haystack v2.0 and removed type:documentation Improvements on the docs labels Feb 23, 2024
@silvanocerza silvanocerza added ignore-for-release-notes PRs with this flag won't be included in the release notes. and removed topic:tests 2.x Related to Haystack v2.0 labels Feb 23, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8019020294

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 89.878%
Totals Coverage Status
Change from base Build 8018141095: -0.003%
Covered Lines: 5212
Relevant Lines: 5799
💛 - Coveralls

@silvanocerza silvanocerza merged commit 0a7dfc1 into main Feb 23, 2024
29 of 30 checks passed
@silvanocerza silvanocerza deleted the revert-evaluators branch February 23, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

Assignees

@silvanocerza silvanocerza

Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@silvanocerza @coveralls @julian-risch