Adding a guard that prevents the tutorial from being executed in every subprocess on windows #729
+712
−670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… every subprocess when using multiprocessing on windows
|
What about the tutorials in jupyter notebook format? Do we have a similar problem there or is it only concerning the .py scripts? |
|
👍 It is only concerning the scripts and not the notebooks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tutorials are now encapsulated in methods and it is checked that the code is executed only by the main process but none of the subprocesses when using multiprocessing. This change only affects Windows users.
On Windows, this check is necessary to prevent the tutorial code from being executed in every subprocess when using multiprocessing. Without the check, every subprocess tries to spawn a new elasticsearch instance, write to the same log file, etc., which leads to "Permission denied" errors or "failed to obtain node locks" exceptions as reported in the following issue
closes #709