Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change signature and docstring for ca_certs parameter #730

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Change signature and docstring for ca_certs parameter #730

merged 1 commit into from
Jan 12, 2021

Conversation

antoniolanza1996
Copy link
Contributor

As discussed with @tholor in #720, I've changed signature and docstring for ca_certs parameter in ElasticsearchDocumentStore.

tholor
tholor approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks a lot @antoniolanza1996 !

@tholor tholor merged commit 1f00599 into deepset-ai:master Jan 12, 2021
@antoniolanza1996 antoniolanza1996 deleted the change_ca_certs_signature branch January 12, 2021 16:32
@tanaysoni tanaysoni mentioned this pull request Jan 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antoniolanza1996 @tholor