use Path class in add_eval_data of haystack.document_store.base.py #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tholor
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
Looking good! Thanks for adding this @Rob192
I think there are more places in Haystack where we could make use of Path and eventually also then update the function signatures to support both types (e.g. filename: Union[str, Path]). However, we can tackle this in a later stage with separate PRs :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR #717, there was an issue on Windows file system paths. This PR aims at fixing this by adding the
Pathclass frompathlib.@Timoeller