Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support filters for DensePassageRetriever + InMemoryDocumentStore #754

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Support filters for DensePassageRetriever + InMemoryDocumentStore #754

merged 2 commits into from
Jan 20, 2021

Conversation

tanaysoni
Copy link
Contributor

@tanaysoni tanaysoni commented Jan 20, 2021 •
edited
Loading

This PR adds supports for filtering documents based on the meta-data when using the DensePassageRetriever with an InMemoryDocumentStore.

@tanaysoni tanaysoni changed the title WIP: Support filters for DensePassageRetriever + InMemoryDocumentStore Support filters for DensePassageRetriever + InMemoryDocumentStore Jan 20, 2021
@tanaysoni tanaysoni requested a review from tholor January 20, 2021 11:51
tholor
tholor approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanaysoni tanaysoni merged commit aa8a366 into master Jan 20, 2021
@tanaysoni tanaysoni deleted the dpr-memory-filters branch January 20, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tanaysoni @tholor