Inmemory store #76
Merged
Inmemory store #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have for use cases when the trained model can be pickled
Adding in-memory store and a unit test. In-memory store is a nice to …
|
In-memory store allows to pickle entire "finder" object and use it in a distributed system more easily, when you can deploy the finder itself as a small service with no dependency on a database. |
|
Merged with upstream and moved tests to pytests. |
|
Thanks again @skirdey, it's good-to-go! |
|
Awesome, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addin in-memory store. It is nice to have when experimenting with notebooks or trying to pickle a trained model.