Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add instance argument to code samples in docstrings for component.py #7622

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

evanderiel
Copy link
Contributor

Related Issues

No issue opened

Proposed Changes:

The instance argument was missing from the sample code in the docstrings for component.set_output_types and component.set_input_types. This caused me to write code that didn't work. I fixed my code, I would like to fix the docs.

How did you test it?

I haven't yet.

Notes for the reviewer

I hope you have a nice day.

Checklist

[X] I have read the contributors guidelines and the code of conduct
[ ] I have updated the related issue with new insights and changes
[ ] I added unit tests and updated the docstrings
[X] I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
[ ] I documented my code
[ ] I ran pre-commit hooks and fixed any issue

@evanderiel evanderiel requested a review from a team as a code owner April 30, 2024 12:58
@evanderiel evanderiel requested review from silvanocerza and removed request for a team April 30, 2024 12:58
@CLAassistant
Copy link

CLAassistant commented Apr 30, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added 2.x Related to Haystack v2.0 topic:core type:documentation Improvements on the docs labels Apr 30, 2024
@silvanocerza silvanocerza added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Apr 30, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8895200860

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.129%

Totals Coverage Status
Change from base Build 8881259484: 0.0%
Covered Lines: 6337
Relevant Lines: 7031

💛 - Coveralls

Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

@silvanocerza silvanocerza merged commit 5de5619 into deepset-ai:main Apr 30, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:core type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants