Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add license header to all modules #7675

Merged
merged 12 commits into from
May 9, 2024
Merged

chore: add license header to all modules #7675

merged 12 commits into from
May 9, 2024

Conversation

masci
Copy link
Contributor

@masci masci commented May 9, 2024

Related Issues

  • fixes n/a

Proposed Changes:

  • Consistently add the license header to all the modules
  • Add a linting step to ensure new all the files have the header

How did you test it?

  • CI

Notes for the reviewer

Checklist

@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label May 9, 2024
@masci masci marked this pull request as ready for review May 9, 2024 13:11
@masci masci requested a review from a team as a code owner May 9, 2024 13:11
@masci masci requested review from davidsbatista and removed request for a team May 9, 2024 13:11
@masci masci changed the title chore: add license header to modules chore: add license header to all modules May 9, 2024
@masci masci enabled auto-merge (squash) May 9, 2024 13:16
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Comment on lines +16 to +17
- name: Skip mypy
run: echo "Skipped mypy"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated: can we also update paths-ignore? they seem outdated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need them at all?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I don't know 🙂

@masci masci merged commit 10c675d into main May 9, 2024
41 checks passed
@masci masci deleted the license-header branch May 9, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. proposal topic:CI topic:core topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants