Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Move tests from test_connect.py in test_pipeline.py and test_utils.py #7742

Merged
merged 1 commit into from
May 24, 2024

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented May 24, 2024

Proposed Changes:

Move Pipeline.connect() tests from test_connect.py in TestPipeline class in test_pipeline.py.

One test has been moved in the newly created test_utils.py instead as it's not a member of Pipeline.

How did you test it?

I ran unit tests locally.

Notes for the reviewer

Part of #7611.

Checklist

@silvanocerza silvanocerza added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label May 24, 2024
@silvanocerza silvanocerza requested a review from masci May 24, 2024 12:46
@silvanocerza silvanocerza self-assigned this May 24, 2024
@silvanocerza silvanocerza requested a review from a team as a code owner May 24, 2024 12:46
@silvanocerza silvanocerza requested review from julian-risch and removed request for a team and julian-risch May 24, 2024 12:46
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9224158098

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.592%

Totals Coverage Status
Change from base Build 9212041025: 0.0%
Covered Lines: 6692
Relevant Lines: 7387

💛 - Coveralls

@silvanocerza silvanocerza merged commit 22289f5 into main May 24, 2024
23 checks passed
@silvanocerza silvanocerza deleted the move-pipeline-connect-tests branch May 24, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants