Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Pipeline run tests rework #7748

Merged
merged 7 commits into from
May 28, 2024
Merged

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented May 27, 2024

Related Issues

Part of #7611.

Proposed Changes:

This PR adds behavioural testing for Pipeline.run().

As of now I just added three simple cases as an example, in further PRs I'll move more and more existing tests.

The included README.md contains instructions on adding new tests.

How did you test it?

I ran tests locally.

Notes for the reviewer

N/A

Checklist

@silvanocerza silvanocerza requested a review from masci May 27, 2024 15:20
@silvanocerza silvanocerza self-assigned this May 27, 2024
@silvanocerza silvanocerza requested review from a team as code owners May 27, 2024 15:20
@silvanocerza silvanocerza requested review from dfokina and vblagoje and removed request for a team and vblagoje May 27, 2024 15:20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been moved above.

@silvanocerza silvanocerza added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label May 27, 2024
@coveralls
Copy link
Collaborator

coveralls commented May 27, 2024

Pull Request Test Coverage Report for Build 9267892584

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.595%

Totals Coverage Status
Change from base Build 9255117123: 0.0%
Covered Lines: 6695
Relevant Lines: 7390

💛 - Coveralls

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@@ -0,0 +1,86 @@
# `Pipeline.run()` behavioural tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

from haystack.testing.factory import component_class


pytestmark = pytest.mark.integration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@silvanocerza silvanocerza merged commit 3dcc21f into main May 28, 2024
25 checks passed
@silvanocerza silvanocerza deleted the pipeline-run-tests-rework branch May 28, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:build/distribution topic:tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants