Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to get metadata values for a key from Elasticsearch #776

Merged
merged 4 commits into from
Feb 1, 2021

Conversation

tanaysoni
Copy link
Contributor

No description provided.

@tanaysoni tanaysoni changed the title WIP: Add method to get metadata values for a key from Elasticsearch Add method to get metadata values for a key from Elasticsearch Jan 26, 2021
@tanaysoni tanaysoni requested a review from tholor January 26, 2021 16:17
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only minor comments regarding the docstring. Feel free to merge after addressing those

haystack/document_store/elasticsearch.py Show resolved Hide resolved
haystack/document_store/elasticsearch.py Show resolved Hide resolved
@tanaysoni tanaysoni force-pushed the es-meta-values branch 2 times, most recently from 98d7893 to 35616cf Compare February 1, 2021 08:48
@tanaysoni tanaysoni merged commit b87dd24 into master Feb 1, 2021
@tanaysoni tanaysoni deleted the es-meta-values branch February 1, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants